帮忙看看这段新建记录代码有没有问题

layaman_999 · 发表于 2012-6-12 19:29:41

If DCount("InvoiceId", "tbTBuyInvoice", "InvoiceId='" & mId & "'") <> 0 ThenDCount会降低效率,建议使用dlookup来检查
，其他问题你都没说，如果运行正常，就算了吧，等基础好了再来检查，毕竟每个人都编写习惯都不一样

layaman_999 · 发表于 2012-6-12 20:47:55

      fm.FilterOn = True
      fm.Filter = "Me.InvoiceId='" & mId & "'" ‘过滤
调换一下顺序看看
fm.Filter = "Me.InvoiceId='" & mId & "'" ‘过滤
fm.FilterOn = True
==========
我觉得你的代码效率不高，可能这样要好点：
On Error GoTo NewTBuyInvoice_Err
Dim mId As String
mId = InputBox("请输入发票号", "提示")
If mId = "" Then Exit Sub

If Nz(DLookup("InvoiceId", "tbTBuyInvoice", "InvoiceId='" & mId & "'"), "") = mId Then
MsgBox "此发票号已经存在,请重新输入!", vbExclamation, "提示"
Exit Sub
End If

'新建发票
'====================
Dim StrSql As String '不清楚你的字段类型，'UserName'为文本, #BuildDate#为日期
StrSql = "insert into tbTBuyInvoice(InvoiceId,BuildDate,BuildMan) "
StrSql = StrSql & " select '" & mId & "', #" & BuildDate & "#, '" & DLookup("EmployeeId", "tbEmployee", "UserName='" & mUserName & "'") & "'"

CurrentProject.Connection.Execute (StrSql)

'打开新记录编辑
      Dim fm As Form
      Set fm = New Form_fmTBuyInvoice  '打开新窗口
      fm.RecordSource = "select * from tbTBuyInvoice where InvoiceId='" & mId & "'"
      fm.AllowAdditions = False  '表头不可编辑
      fm.Caption = "编辑发票" & mId
      fm.Visible = True
      coTBuyInvoice.Add Item:=fm, Key:=CStr(fm.Hwnd)
      Set fm = Nothing
NewTBuyInvoice_Exit:
Exit Sub
NewTBuyInvoice_Err:
MsgBox Err.Description
Resume NewTBuyInvoice_Exit

layaman_999 · 发表于 2012-6-12 20:48:07

   fm.FilterOn = True
      fm.Filter = "Me.InvoiceId='" & mId & "'" ‘过滤
调换一下顺序看看
fm.Filter = "Me.InvoiceId='" & mId & "'" ‘过滤
fm.FilterOn = True
==========
我觉得你的代码效率不高，可能这样要好点：
On Error GoTo NewTBuyInvoice_Err
Dim mId As String
mId = InputBox("请输入发票号", "提示")
If mId = "" Then Exit Sub

If Nz(DLookup("InvoiceId", "tbTBuyInvoice", "InvoiceId='" & mId & "'"), "") = mId Then
MsgBox "此发票号已经存在,请重新输入!", vbExclamation, "提示"
Exit Sub
End If

'新建发票
'====================
Dim StrSql As String '不清楚你的字段类型，'UserName'为文本, #BuildDate#为日期
StrSql = "insert into tbTBuyInvoice(InvoiceId,BuildDate,BuildMan) "
StrSql = StrSql & " select '" & mId & "', #" & BuildDate & "#, '" & DLookup("EmployeeId", "tbEmployee", "UserName='" & mUserName & "'") & "'"

CurrentProject.Connection.Execute (StrSql)

'打开新记录编辑
      Dim fm As Form
      Set fm = New Form_fmTBuyInvoice  '打开新窗口
      fm.RecordSource = "select * from tbTBuyInvoice where InvoiceId='" & mId & "'"
      fm.AllowAdditions = False  '表头不可编辑
      fm.Caption = "编辑发票" & mId
      fm.Visible = True
      coTBuyInvoice.Add Item:=fm, Key:=CStr(fm.Hwnd)
      Set fm = Nothing
NewTBuyInvoice_Exit:
Exit Sub
NewTBuyInvoice_Err:
MsgBox Err.Description
Resume NewTBuyInvoice_Exit

layaman_999 · 发表于 2012-6-12 20:50:04

回复需要审核？

layaman_999 · 发表于 2012-6-12 20:57:43

Public coTBuyInvoice As New Collection

Public Sub NewTBuyInvoice()
   fm.FilterOn = True
      fm.Filter = "Me.InvoiceId='" & mId & "'" ‘过滤
调换一下顺序看看
fm.Filter = "Me.InvoiceId='" & mId & "'" ‘过滤
fm.FilterOn = True
==========
我觉得你的代码效率不高，可能这样要好点：
Public Sub NewTBuyInvoice()
On Error GoTo NewTBuyInvoice_Err
Dim mId As String
mId = InputBox("请输入发票号", "提示")
If mId = "" Then Exit Sub

If Nz(DLookup("InvoiceId", "tbTBuyInvoice", "InvoiceId='" & mId & "'"), "") = mId Then
MsgBox "此发票号已经存在,请重新输入!", vbExclamation, "提示"
Exit Sub
End If

'新建发票
'====================
Dim StrSql As String '不清楚你的字段类型，'UserName'为文本, #BuildDate#为日期
StrSql = "insert into tbTBuyInvoice(InvoiceId,BuildDate,BuildMan) "
StrSql = StrSql & " select '" & mId & "', #" & BuildDate & "#, '" & DLookup("EmployeeId", "tbEmployee", "UserName='" & mUserName & "'") & "'"

CurrentProject.Connection.Execute (StrSql)

'打开新记录编辑
      Dim fm As Form
      Set fm = New Form_fmTBuyInvoice  '打开新窗口
      fm.RecordSource = "select * from tbTBuyInvoice where InvoiceId='" & mId & "'"
      fm.AllowAdditions = False  '表头不可编辑
      fm.Caption = "编辑发票" & mId
      fm.Visible = True
      coTBuyInvoice.Add Item:=fm, Key:=CStr(fm.Hwnd)
      Set fm = Nothing
NewTBuyInvoice_Exit:
Exit Sub
NewTBuyInvoice_Err:
MsgBox Err.Description
Resume NewTBuyInvoice_Exit
end sub

layaman_999 · 发表于 2012-6-12 22:48:58

我觉得你的代码效率不高，可能这样要好点：
Public Sub NewTBuyInvoice()
On Error GoTo NewTBuyInvoice_Err
Dim mId As String
mId = InputBox("请输入发票号", "提示")
If mId = "" Then Exit Sub

If Nz(DLookup("InvoiceId", "tbTBuyInvoice", "InvoiceId='" & mId & "'"), "") = mId Then
MsgBox "此发票号已经存在,请重新输入!", vbExclamation, "提示"
Exit Sub
End If

'新建发票
'====================
Dim StrSql As String '不清楚你的字段类型，'UserName'为文本, #BuildDate#为日期
StrSql = "insert into tbTBuyInvoice(InvoiceId,BuildDate,BuildMan) "
StrSql = StrSql & " select '" & mId & "', #" & BuildDate & "#, '" & DLookup("EmployeeId", "tbEmployee", "UserName='" & mUserName & "'") & "'"

CurrentProject.Connection.Execute (StrSql)

'打开新记录编辑
      Dim fm As Form
      Set fm = New Form_fmTBuyInvoice  '打开新窗口
      fm.RecordSource = "select * from tbTBuyInvoice where InvoiceId='" & mId & "'"
      fm.AllowAdditions = False  '表头不可编辑
      fm.Caption = "编辑发票" & mId
      fm.Visible = True
      coTBuyInvoice.Add Item:=fm, Key:=CStr(fm.Hwnd)
      Set fm = Nothing
NewTBuyInvoice_Exit:
Exit Sub
NewTBuyInvoice_Err:
MsgBox Err.Description
Resume NewTBuyInvoice_Exit
end sub

layaman_999 · 发表于 2012-6-12 22:49:36

On Error GoTo NewTBuyInvoice_Err
Dim mId As String
mId = InputBox("请输入发票号", "提示")
If mId = "" Then Exit Sub

If Nz(DLookup("InvoiceId", "tbTBuyInvoice", "InvoiceId='" & mId & "'"), "") = mId Then
MsgBox "此发票号已经存在,请重新输入!", vbExclamation, "提示"
Exit Sub
End If

'新建发票
'====================
Dim StrSql As String '不清楚你的字段类型，'UserName'为文本, #BuildDate#为日期
StrSql = "insert into tbTBuyInvoice(InvoiceId,BuildDate,BuildMan) "
StrSql = StrSql & " select '" & mId & "', #" & BuildDate & "#, '" & DLookup("EmployeeId", "tbEmployee", "UserName='" & mUserName & "'") & "'"

CurrentProject.Connection.Execute (StrSql)

'打开新记录编辑
      Dim fm As Form
      Set fm = New Form_fmTBuyInvoice  '打开新窗口
      fm.RecordSource = "select * from tbTBuyInvoice where InvoiceId='" & mId & "'"
      fm.AllowAdditions = False  '表头不可编辑
      fm.Caption = "编辑发票" & mId
      fm.Visible = True
      coTBuyInvoice.Add Item:=fm, Key:=CStr(fm.Hwnd)
      Set fm = Nothing
NewTBuyInvoice_Exit:
Exit Sub
NewTBuyInvoice_Err:
MsgBox Err.Description
Resume NewTBuyInvoice_Exit

layaman_999 · 发表于 2012-6-12 22:49:52

On Error GoTo NewTBuyInvoice_Err
Dim mId As String
mId = InputBox("请输入发票号", "提示")
If mId = "" Then Exit Sub

If Nz(DLookup("InvoiceId", "tbTBuyInvoice", "InvoiceId='" & mId & "'"), "") = mId Then
MsgBox "此发票号已经存在,请重新输入!", vbExclamation, "提示"
Exit Sub
End If

'新建发票
'====================
Dim StrSql As String '不清楚你的字段类型，'UserName'为文本, #BuildDate#为日期
StrSql = "insert into tbTBuyInvoice(InvoiceId,BuildDate,BuildMan) "
StrSql = StrSql & " select '" & mId & "', #" & BuildDate & "#, '" & DLookup("EmployeeId", "tbEmployee", "UserName='" & mUserName & "'") & "'"

CurrentProject.Connection.Execute (StrSql)

'打开新记录编辑
      Dim fm As Form
      Set fm = New Form_fmTBuyInvoice  '打开新窗口
      fm.RecordSource = "select * from tbTBuyInvoice where InvoiceId='" & mId & "'"
      fm.AllowAdditions = False  '表头不可编辑
      fm.Caption = "编辑发票" & mId
      fm.Visible = True
      coTBuyInvoice.Add Item:=fm, Key:=CStr(fm.Hwnd)
      Set fm = Nothing
NewTBuyInvoice_Exit:
Exit Sub
NewTBuyInvoice_Err:
MsgBox Err.Description
Resume NewTBuyInvoice_Exit

layaman_999 · 发表于 2012-6-15 21:34:13

你先把（ fm.AllowAdditions = False ‘表头不可编辑）删了，看看是什么情况
然后看看以V开头的表头数据是否已经已经写入表中，如果没有写入的话，那你看看是不是字段类型不对还是字符长度不够。
==========
这些问题要自己多调试调试，看看究竟出问题在哪行代码

layaman_999 · 发表于 2012-6-16 10:17:43

原来是ADP啊
StrSql = StrSql & " select '" & mId & "', '" & BuildDate & "', '" & DLookup("EmployeeId", "tbEmployee", "UserName='" & mUserName & "'") & "'"

日期要把#改为'

帐号		自动登录	找回密码
密码			注册

群介绍
Access培训群 (792054000)
Access免费培训2群 (163530137)
Access免费培训群 (833510950)
Access免费培训群2 (792054000)
Access交流总群 (5004108)

主题相关群

地区相关群[您还没设置居住地]

[模块/函数] 帮忙看看这段新建记录代码有没有问题

群介绍
主题无相 (随机显示版	同地区群块其他地区)